{"id":42,"date":"2021-02-01T06:45:43","date_gmt":"2021-02-01T06:45:43","guid":{"rendered":"http:\/\/blogs.oregonstate.edu\/hastinar\/?p=42"},"modified":"2021-02-01T06:45:44","modified_gmt":"2021-02-01T06:45:44","slug":"first-code-review","status":"publish","type":"post","link":"https:\/\/blogs.oregonstate.edu\/hastinar\/2021\/02\/01\/first-code-review\/","title":{"rendered":"First Code Review"},"content":{"rendered":"\n<p>This week we have a code review where we have to review what we created for this previous sprint. This previous sprint as scrum master I was tasked with creating the header for the website for both designs being created this week. For this I just built the one that I thought that had the most complexities, for the other version some changes are needed and it may be made with some removals.<\/p>\n\n\n\n<p>For the header this week I reviewed the standard layout of the Shopify \u201ctheme.liquid\u201d file <a href=\"https:\/\/www.shopify.com\/partners\/blog\/115244038-an-overview-of-liquid-shopifys-templating-language\">(1)<\/a>. This file is the main file that contains most of the theme\u2019s sections starting with the header section that I want to change for this week. For the first header design the plan is to have from left to right to have an ATF logo, name of the farm, farm address, map <a href=\"https:\/\/docs.mapbox.com\/mapbox-gl-js\/example\/marker-from-geocode\/\">(2)<\/a>, and navigation bar <a href=\"https:\/\/shopify.github.io\/liquid-code-examples\/example\/nested-navigation\">(3)<\/a>. To do this I need to convert the photo we have to a \u201c.svg\u201d type file that creates a more efficient image with vectors <a href=\"https:\/\/shopify.github.io\/liquid-code-examples\/example\/header-logo\">(4)<\/a>. Next I created a \u201cstyle.css\u201d sheet to be preloaded in the header for the design of the header. This style css file is where the positions and colors for theme\u2019s header are set. This worked at one point, and then somewhere down the line stopped working, and I may address this in our next meeting since I am confident another team member may have some helpful insight.<\/p>\n\n\n\n<p>Next I created a \u201cheader.liquid\u201d section file for the header content <a href=\"https:\/\/shopify.dev\/docs\/themes\/sections\">(5)<\/a>. Looking forward, I would like to connect this header section file with the content variable for the header section, and that is because I have yet to integrate that content variable. This \u201cheader.liquid\u201d file is made in conjunction with the \u201ctheme.liquid\u201d and in placed in the header with the \u201c{% section &#8216;header&#8217; %}\u201d section command referencing the class tag. This header is going to carry many settings for across all pages, this is done to organized, and for reducing repetitive code. This new directory for the theme, called sections will allow us to access global objects, with special liquid tags. This header section liquid file may also be created for a section such as the footer.<\/p>\n\n\n\n<p>Last of all, I worked with themekit briefly on my system, by connecting the API, and changing settings to be able to create new themes from my command line.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>This week we have a code review where we have to review what we created for this previous sprint. This previous sprint as scrum master I was tasked with creating the header for the website for both designs being created this week. For this I just built the one that I thought that had the [&hellip;]<\/p>\n","protected":false},"author":10704,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[],"class_list":["post-42","post","type-post","status-publish","format-standard","hentry","category-uncategorized"],"_links":{"self":[{"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/posts\/42","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/users\/10704"}],"replies":[{"embeddable":true,"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/comments?post=42"}],"version-history":[{"count":1,"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/posts\/42\/revisions"}],"predecessor-version":[{"id":43,"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/posts\/42\/revisions\/43"}],"wp:attachment":[{"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/media?parent=42"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/categories?post=42"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blogs.oregonstate.edu\/hastinar\/wp-json\/wp\/v2\/tags?post=42"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}